fix: throw reject when SingleThreadExecutor drainTo in progress and queue is empty #4488
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4465
Motivaction
In
SingleThreadExecutor
, therunner
drains the fullqueue
into thelocalTasks
, when thelocalTasks
has not been run, thequeue
is really full(thequeue
is empty in the memory) at this point.When calling the
execute()
method, which shouldn't add therunnable
to thequeue
, which would double the actual number ofrunable
, increasing memory usage and potential OOM issues.Changes
Add a variable to record the
runnable
count: